Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Files.createSymbolicLink instead of shelling out #65

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Nov 14, 2024

No description provided.

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2024

Caused by: org.apache.maven.plugin.PluginIncompatibleException: The plugin org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-2-SNAPSHOT has unmet prerequisites: Required Maven version 4.0.0-beta-5 is not met by current version 4.0.0-beta-3

@cstamas
Copy link
Member

cstamas commented Nov 14, 2024

No, but:

[INFO] Build Summary:
[INFO]   Passed: 9, Failed: 2, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
Error:  The following builds failed:
Error:  *  symlink-dont-follow/pom.xml
Error:  *  dangling-symlinks/pom.xml

GH Actions should be observed, the Jenkins instance is not setup (yet?)
If you want to change maven3 plugin, use the branch https://github.com/apache/maven-clean-plugin/tree/maven-clean-plugin-3.x

@elharo
Copy link
Contributor Author

elharo commented Nov 14, 2024

Yes, those two failing tests are weird. It looks like Beanshell is having trouble matching the argument types and is looking for a method that matches the actual type rather than the interface supertype.

@elharo
Copy link
Contributor Author

elharo commented Nov 16, 2024

Failures now appear to be in the CI script:

plugin:4.0.0-beta-2-SNAPSHOT:clean (default-clean) on project exclude-default-dirs: The plugin org.apache.maven.plugins:maven-clean-plugin:4.0.0-beta-2-SNAPSHOT has unmet prerequisites: Required Maven version 4.0.0-beta-5 is not met by current version 4.0.0-beta-3

@elharo elharo marked this pull request as ready for review November 16, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants