[MCOMPILER-529] information that it's possible to use "8" as source/target #245
Conversation
elharo
changed the title
|
It's possible to set .release property not only for Java 9+ but also do or Java 8. Plugin will skip passing this parameter to compiler for Java 8 |
|
Sorry, totally missed the notification about your comment :/
As this information is already written in the example of the release property, I added a link at the start of the page (similar to M3 and M4 guides about multi module / multi subproject) to use this property if plugin version is 3.13.0 or higher (this version is noticed on the release property page), as it's the preferred option anyway nowadays. We can also think about (in a separate issues/PR) to merge both examples / "remove" from the menu to point users more directly to using the release property. |
|
Please notice, that master - version 4.x require JDK 17 |
|
maybe this PR should be targeted to 3.x branch |
| @@ -82,3 +85,9 @@ Setting the <<<-source>>> and <<<-target>>> of the Java Compiler | |||
| In the same way, setting the <<<source>>> option does not guarantee that your code actually compiles on a JDK with | |||
| the specified version. To compile your code with a specific JDK version, different than the one used to launch Maven, | |||
| refer to the {{{../examples/compile-using-different-jdk.html}Compile Using A Different JDK}} example. | |||
|
|
|||
| <<Note:>> When you build your project using newer JDK (9+) you can also use "8" instead of "1.8" to set Java 8 as the | |||
There was a problem hiding this comment.
JDK 17 is minimum for 4.x
Considering this, I decided to make a larger update of the docs and create a new PR, after I have done this. |
Created a draft for an additional note about the alternatives.
If you want have suggestions to improve it, please leave a comment and I will change it.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MCOMPILER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).[ERROR] The following builds failed:
[ERROR] * mcompiler-120\pom.xml
[ERROR] * MCOMPILER-346\pom.xml
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.