[MCOMPILER-341] Compile module descriptors with TestCompilerMojo #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2018
sormuras
commented
May 12, 2018
| @Test | ||
| void moduleNameIsFoo() | ||
| { | ||
| Assumptions.assumeTrue( Foo.class.getModule().isNamed(), "Calculator resides in a named module" ); |
There was a problem hiding this comment.
Fix copy and paste error: Foo it is, not Calculator.
sormuras
commented
May 12, 2018
| def jpmsArgs = new File( basedir, 'target/test-classes/META-INF/jpms.args' ) | ||
| def lines = jpmsArgs.readLines() | ||
| assert lines[0] == "--patch-module" // TODO --patch-module is not required here! | ||
| assert lines[1] == "foo=" |
There was a problem hiding this comment.
foo= points to an empty value. It shoud point to the src/main/java directory.
Prior to this commit module descriptors `module-info.java` were not compiled by the TestCompilerMojo. This commit introduces support for test sources organized with module descriptors. See motivation: https://twitter.com/rfscholte/status/927132319374331904 https://issues.apache.org/jira/browse/MCOMPILER-341
sormuras
changed the title
|
2 black-box and 1 white-box integration tests implemented:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit module descriptors
module-info.javawere not compiled by the TestCompilerMojo. This commit introduces support for test sources organized with module descriptors.See motivation: https://twitter.com/rfscholte/status/927132319374331904
Supersedes: apache/maven-plugins#139