[MCOMPILER-205] Add a boolean to generate missing package-info classes by default #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Feb 21, 2022
| if ( path.startsWith( root ) ) | ||
| { | ||
| String rel = path.substring( root.length() ); | ||
| Set<File> files = sourceMapping.getTargetFiles( getOutputDirectory(), rel ); |
|
This change in MCOMPILER has started to cause problems in various tooling that scans JARs for bytecode scanning reasons. Those users on limited JVMs (android, java 8 compact builds, embedded systems, etc) are also being impacted by this being true. |
|
+1 it is also true on plain JVM and EE containers where it has side effects (even if some can be silently recovered) so agree default should change to be backward compatible in next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MCOMPILER-205
This PR provides an option (turned on by default) to generate class files for missing
package-infoclasses. This happens when thepackage-info.javasource file only contains a javadoc and no annotations on the package.This can be turned on some JDK using
-Xpkginfo:always, but that may not work on all JDKs.This option is turned on by default because the generated class files are valid, so they should not cause any problem, and the current behavior means that incremental compilation is broken, which is a really annoying problem and the root cause is quite difficult to analyse.