Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1410] Track used declared dependency usage by referencing classes #126

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jaredstehler
Copy link
Contributor

As a follow-on to https://issues.apache.org/jira/browse/MSHARED-1407

This will also map uses of used declared dependencies to their referencing classes.

We use this in our internal dependency analyzer to support validation for migrating classes to new packages - for classes in a migration, we select their new artifact as a used dependency and not their old one.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes. Also be sure having selected the correct component.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@jaredstehler
Copy link
Contributor Author

gentle bump; anything I can do to help get this integrated?

@slawekjaranowski slawekjaranowski self-requested a review September 16, 2024 10:18
@slawekjaranowski
Copy link
Member

@jaredstehler - thanks for patience

@slawekjaranowski slawekjaranowski merged commit 843e8fd into apache:master Sep 30, 2024
20 checks passed
@jaredstehler jaredstehler deleted the js-track-used-decl-deps branch October 1, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants