[MDEP-708] - dependency:analyze recommends test scope for test-only artifacts that have non-test scope #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jul 10, 2020
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/dependency/analyzer/ProjectDependencyAnalysis.java
Outdated
Show resolved
Hide resolved
...t/java/org/apache/maven/shared/dependency/analyzer/DefaultProjectDependencyAnalyzerTest.java
Outdated
Show resolved
Hide resolved
elharo
approved these changes
Jul 10, 2020
elharo
requested changes
Jul 10, 2020
|
Thought we might run into this. The dependency identification fails on test dependencies when using Java 7. Last commit should fix the issue, I'll monitor the CI |
|
Actually @elharo need you to trigger a build for me. |
elharo
approved these changes
Jul 11, 2020
|
Jenkins passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works similarly to the current logic for getting unused dependencies and declared; looks in output src and test folders and compares what it finds.
Tried to make the test less complicated with only one pom but couldn't get it working.