Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1035] Get rid of maven-plugin-testing-tools for IT test #50

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

slawekjaranowski
Copy link
Member

IT tests will be executed by maven-invoker-plugin


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes. Also be sure having selected the correct component.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

IT tests will be executed by maven-invoker-plugin
@michael-o
Copy link
Member

That's massive..., will run...

@slawekjaranowski
Copy link
Member Author

Idea and way how to was done:

  • add simple maven plugin src/it/setup-mock-plugin/src/main/java/it/test/MockAnalyzeMojo.java
  • build and instal plugin in setup job of m-invoker-p
  • plugin generate target/analysis.txt with result of executing
  • use plugin in each IT test
  • assert content of target/analysis.txt in verify.groovy

pom.xml Show resolved Hide resolved
@slawekjaranowski
Copy link
Member Author

I can't use new version of maven-plugin-testing-harness ... because for tests MavenProject instance is needed ...
MavenProject must contains resolve all dependency which is difficult to mock

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass!

@slawekjaranowski
Copy link
Member Author

All test pass ... on GH and Jenkins
even with 18-ea on localhost 😸

@slawekjaranowski slawekjaranowski merged commit 749ebcd into master Feb 17, 2022
@slawekjaranowski slawekjaranowski deleted the MSHARED-1035 branch February 17, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants