MSHARED-1039: Fix array parsing #55
Merged
+128
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Will be good to add some of test. Unit or IT, of course we can extends existing one. |
slawekjaranowski
requested changes
Feb 23, 2022
src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ResultCollectorTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+63
to
+67
| do | ||
| { | ||
| ++i; | ||
| } | ||
| while ( name.charAt( i ) == '[' ); // could have array of array ... |
There was a problem hiding this comment.
can name contains multiple [ ... ?
we don't check length of name - can couse IndexOutOfBoundsException
There was a problem hiding this comment.
name can contain any number of '[' - see Field Descriptors in jvm spec.
Yes, we could have IndexOutOfBoundsException if class is malformed. Does it matter what sort of exception is thrown?
There was a problem hiding this comment.
@slawekjaranowski - any thoughts?
slawekjaranowski
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays [of Arrays]+ of class types should add just the class type to dependency set
Arrays of scalar types should not be added
[ x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[ x] In any other case, please file an Apache Individual Contributor License Agreement.