Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDEP-940] Use Resolver API instead of m-a-t for resolving artifacts #410

Merged
merged 1 commit into from
Jun 16, 2024
Merged

[MDEP-940] Use Resolver API instead of m-a-t for resolving artifacts #410

merged 1 commit into from
Jun 16, 2024

Conversation

slawekjaranowski
Copy link
Member

@michael-o
Copy link
Member

MAT is still on the CP, no?

@slawekjaranowski
Copy link
Member Author

MAT is still on the CP, no?

Yes it is ... I do it step by step

@michael-o michael-o marked this pull request as draft June 8, 2024 20:01
@michael-o
Copy link
Member

MAT is still on the CP, no?

Yes it is ... I do it step by step

Alright, let's convert to a draft.

@slawekjaranowski
Copy link
Member Author

MAT is still on the CP, no?

Yes it is ... I do it step by step

Alright, let's convert to a draft.

Why draft ... we can merge step by step with small changes.

@michael-o
Copy link
Member

MAT is still on the CP, no?

Yes it is ... I do it step by step

Alright, let's convert to a draft.

Why draft ... we can merge step by step with small changes.

I assumed that you wanted to work on a complete PR. If you think that PRs are seftcontained, that is fine. You decide.

@michael-o michael-o assigned michael-o and unassigned michael-o Jun 8, 2024
@michael-o michael-o marked this pull request as ready for review June 8, 2024 20:40
@michael-o michael-o requested a review from cstamas June 8, 2024 20:43
@slawekjaranowski
Copy link
Member Author

Why draft ... we can merge step by step with small changes.

I assumed that you wanted to work on a complete PR. If you think that PRs are seftcontained, that is fine. You decide.

Step by step ... other places is more complicated, eg use additional remote or local repository defined by user

@slawekjaranowski slawekjaranowski merged commit 82a9d60 into master Jun 16, 2024
51 checks passed
@slawekjaranowski slawekjaranowski deleted the rm-mta-resolve branch June 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas Awaiting requested review from cstamas

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @michael-o