-
Notifications
You must be signed in to change notification settings - Fork 186
Update maven-dependency-analyzer to support Java24 #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit updates the analyser version which supports reading byte code generated by Java 24. Fixes apache#524
|
Tests failed: Running post-build script: /home/runner/work/maven-dependency-plugin/maven-dependency-plugin/target/it/mdep-779-analyze-only-verbose-shows-class-names/verify.bsh |
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdep-779-analyze-only-verbose-shows-class-names likely needs to be updated
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the warning is
String expected = "[WARNING] Used undeclared dependencies found:\n" +
"[WARNING] xml-apis:xml-apis:jar:1.4.01:compile\n" +
"[WARNING] class org.apache.xmlcommons.Version\n" +
"[WARNING] Unused declared dependencies found:\n" +
"[WARNING] net.java.dev.msv:xsdlib:jar:2022.7:compile";
The new version of the dependency analyzer specifically avoids warning about xml-apis:xml-apis so the upgrade does require this fix.
|
@elharo Please assign appropriate label to PR according to the type of change. |

This commit updates the analyser version which supports reading byte code generated by Java 24.
Fixes #524
Following this checklist to help us incorporate your
contribution quickly and easily:
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Run
mvn verifyto make sure basic checks pass.You have run the integration tests successfully (
mvn -Prun-its verify). They build under Java 23 with some errors, but fail to build under 24.This IT test passes without the analyzer update. I'll take a look later when I have time to see if I see whats failing, tho I'm unfamiliar with both code bases.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.