Skip to content

Conversation

@talios
Copy link
Contributor

@talios talios commented May 13, 2025

This commit updates the analyser version which supports reading byte code generated by Java 24.

Fixes #524

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.

  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.

  • Run mvn verify to make sure basic checks pass.

  • You have run the integration tests successfully (mvn -Prun-its verify). They build under Java 23 with some errors, but fail to build under 24.

    Build Summary:
    [INFO]   Passed: 84, Failed: 1, Errors: 0, Skipped: 0
    [INFO] -------------------------------------------------
    [ERROR] The following builds failed:
    [ERROR] *  mdep-779-analyze-only-verbose-shows-class-names/pom.xml
    

This IT test passes without the analyzer update. I'll take a look later when I have time to see if I see whats failing, tho I'm unfamiliar with both code bases.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This commit updates the analyser version which supports reading byte
code generated by Java 24.

Fixes apache#524
@elharo elharo self-requested a review May 19, 2025 02:30
@anuragagarwal561994
Copy link

Screenshot 2025-06-18 at 6 45 38 PM

I think there is no issue as such but this dependency is not used and declared, I compiled on my local as well and it works.

@elharo
Copy link
Contributor

elharo commented Jun 18, 2025

Tests failed:

Running post-build script: /home/runner/work/maven-dependency-plugin/maven-dependency-plugin/target/it/mdep-779-analyze-only-verbose-shows-class-names/verify.bsh
java.lang.Exception: Expected warning missing
at java.base/jdk.internal.reflect.NativeConstructorAcc

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the warning is

String expected = "[WARNING] Used undeclared dependencies found:\n" +
                  "[WARNING]    xml-apis:xml-apis:jar:1.4.01:compile\n" +
                  "[WARNING]       class org.apache.xmlcommons.Version\n" +
                  "[WARNING] Unused declared dependencies found:\n" +
                  "[WARNING]    net.java.dev.msv:xsdlib:jar:2022.7:compile";

The new version of the dependency analyzer specifically avoids warning about xml-apis:xml-apis so the upgrade does require this fix.

@slawekjaranowski slawekjaranowski requested a review from elharo July 6, 2025 22:14
@slawekjaranowski
Copy link
Member

@elharo @talios IT fixed

@elharo elharo merged commit 88585aa into apache:master Jul 7, 2025
20 checks passed
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

@elharo Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the next-release milestone Jul 7, 2025
@elharo elharo added dependencies Pull requests that update a dependency file priority:major Major loss of function labels Jul 7, 2025
@slawekjaranowski slawekjaranowski added enhancement New feature or request and removed dependencies Pull requests that update a dependency file labels Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:major Major loss of function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analyzing a project with Java 24 as a compilation target doesn't work

4 participants