Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEAR-327] update to parent pom 39 #97

Closed
wants to merge 1 commit into from
Closed

[MEAR-327] update to parent pom 39 #97

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Aug 30, 2023

40 breaks integration tests, so take this one step at a time.

@elharo elharo requested a review from slachiewicz August 30, 2023 11:50
@slachiewicz
Copy link
Member

Separate commit for version upgrade and then 2nd with reformat so we can add it to ignored

slachiewicz
slachiewicz reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new line type issue. I see the full file changes

@elharo
Copy link
Contributor Author

elharo commented Aug 30, 2023

That would mean there's a commit that doesn't build.

@slachiewicz
Copy link
Member

Yes. That's how we do in all repos

@slachiewicz
Copy link
Member

You have duplicate license headers

@pzygielo pzygielo mentioned this pull request Oct 4, 2024
Merged
@slachiewicz
Copy link
Member

Superseded by #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @slachiewicz