Skip to content

JUnit Jupiter best practices #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slachiewicz merged 1 commit into from
Nov 9, 2025
Merged

JUnit Jupiter best practices #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/test/java/org/apache/maven/plugins/ejb/IncludesExcludesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@
import java.util.Arrays;
import java.util.Collections;

import org.junit.Assert;
import org.junit.Test;

import static org.junit.Assert.assertArrayEquals;

public class IncludesExcludesTest {

@Test
Expand All @@ -32,8 +33,8 @@ public void emptyListsShouldResultInZeroSizeResults() {
Collections.<String>emptyList(), Collections.<String>emptyList(),
Collections.<String>emptyList(), Collections.<String>emptyList());

Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
assertArrayEquals(new String[0], ie.resultingIncludes());
assertArrayEquals(new String[0], ie.resultingExcludes());
}

@Test
Expand All @@ -44,8 +45,8 @@ public void nullForIncludesShouldResultInZeroSizeResults() {
Collections.<String>emptyList(),
Collections.<String>emptyList());

Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
assertArrayEquals(new String[0], ie.resultingIncludes());
assertArrayEquals(new String[0], ie.resultingExcludes());
}

@Test
Expand All @@ -56,26 +57,26 @@ public void nullForExcludesShouldResultInZeroSizeResults() {
Collections.<String>emptyList(),
Collections.<String>emptyList());

Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
assertArrayEquals(new String[0], ie.resultingIncludes());
assertArrayEquals(new String[0], ie.resultingExcludes());
}

@Test
public void nonNullForDefaultExcludesShouldResultInExcludesWithDefaultExcludes() {
IncludesExcludes ie =
new IncludesExcludes(null, null, Collections.<String>emptyList(), Arrays.asList("**/package.html"));

Assert.assertArrayEquals(ie.resultingIncludes(), new String[0]);
Assert.assertArrayEquals(ie.resultingExcludes(), new String[] {"**/package.html"});
assertArrayEquals(new String[0], ie.resultingIncludes());
assertArrayEquals(new String[] {"**/package.html"}, ie.resultingExcludes());
}

@Test
public void nonNullForDefaultIncludesShouldResultInIncludesWithDefaultIncludes() {
IncludesExcludes ie =
new IncludesExcludes(null, null, Arrays.asList("**/package.html"), Collections.<String>emptyList());

Assert.assertArrayEquals(ie.resultingIncludes(), new String[] {"**/package.html"});
Assert.assertArrayEquals(ie.resultingExcludes(), new String[0]);
assertArrayEquals(new String[] {"**/package.html"}, ie.resultingIncludes());
assertArrayEquals(new String[0], ie.resultingExcludes());
}

@Test
Expand All @@ -84,7 +85,7 @@ public void nonNullIncludesShouldResultInTheSameIncludes() {
Arrays.asList("**/package.html"), null,
Arrays.asList("**/site.html"), null);

Assert.assertArrayEquals(ie.resultingIncludes(), new String[] {"**/package.html"});
assertArrayEquals(new String[] {"**/package.html"}, ie.resultingIncludes());
}

@Test
Expand All @@ -93,6 +94,6 @@ public void nonNullExcludesShouldResultInTheSameExcludes() {
null, Arrays.asList("**/package.html"),
null, Arrays.asList("**/site.html"));

Assert.assertArrayEquals(ie.resultingExcludes(), new String[] {"**/package.html"});
assertArrayEquals(new String[] {"**/package.html"}, ie.resultingExcludes());
}
}