[MENFORCER-495] Remove "JAVA_HOME" from rule violation message #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Jan 12, 2025
| @@ -76,15 +76,15 @@ public void execute() throws EnforcerRuleException { | |||
| String message = getMessage(); | |||
| if (message == null) { | |||
| message = String.format( | |||
| "%s is an excluded Required Java Vendor (JAVA_HOME=%s)", | |||
| "%s is an excluded Required Java Vendor (Detected JDK %s)", | |||
| SystemUtils.JAVA_VENDOR, SystemUtils.JAVA_HOME); | ||
| } | ||
| throw new EnforcerRuleException(message); | ||
| } else if (includes != null && !includes.contains(SystemUtils.JAVA_VENDOR)) { | ||
| String message = getMessage(); | ||
| if (message == null) { | ||
| message = String.format( | ||
| "%s is not an included Required Java Vendor (JAVA_HOME=%s)", | ||
| "%s is not an included Required Java Vendor (Detected JDK %s)", |
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/version/RequireJavaVersion.java
Show resolved
Hide resolved
elharo
changed the title
michael-o
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.