[MSKINS-242] Replace deprecated prettify JS library #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
changed the title
|
This draft includes these languages: |
kwin
reviewed
Sep 12, 2024
| @@ -136,11 +137,13 @@ under the License. | |||
| <!-- add skin-info --> | |||
| </resource> | |||
|
|
|||
| <!-- include the print.css --> | |||
| <!-- include the some files --> | |||
There was a problem hiding this comment.
The comment is not helpful and contains a typo, let us remove it altogether.
|
@kwin, do you want to work on this? Before 2.0.0 GA? I won't be able to do so because it requires some significant amount of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kwin Here is a very early draft. Problematic. Bootstrap's padding and highlight.js padding add up and make it abysmal:
It will take time to make it look like:
