Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump org.apache.maven.shared:maven-shared-utils from 3.2.1 to 3.4.2 #9

Closed
wants to merge 1 commit into from
Closed

Bump org.apache.maven.shared:maven-shared-utils from 3.2.1 to 3.4.2 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
<version>3.2.1</version>
<version>3.4.2</version>
</dependency>

<dependency>
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/apache/maven/shared/jarsigner/DefaultJarSigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.maven.shared.utils.cli.javatool.AbstractJavaTool;
import org.apache.maven.shared.utils.cli.javatool.JavaToolException;
import org.codehaus.plexus.component.annotations.Component;
import org.slf4j.LoggerFactory;

/**
* Default implementation of component {@link JarSigner}.
Expand All @@ -40,7 +41,7 @@ public DefaultJarSigner() {
@Override
protected Commandline createCommandLine(JarSignerRequest request, String javaToolFile) throws JavaToolException {
JarSignerCommandLineBuilder cliBuilder = new JarSignerCommandLineBuilder();
cliBuilder.setLogger(getLogger());
cliBuilder.setLogger(LoggerFactory.getLogger(this.getClass()));
cliBuilder.setJarSignerFile(javaToolFile);
try {
Commandline cli = cliBuilder.build(request);
Expand Down
7 changes: 3 additions & 4 deletions src/main/java/org/apache/maven/shared/jarsigner/JarSignerCommandLineBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import org.apache.maven.shared.utils.StringUtils;
import org.apache.maven.shared.utils.cli.Arg;
import org.apache.maven.shared.utils.cli.Commandline;
import org.codehaus.plexus.logging.Logger;
import org.codehaus.plexus.logging.console.ConsoleLogger;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* To build the command line for a given {@link JarSignerRequest}.
Expand All @@ -34,9 +34,8 @@
* @since 1.0
*/
public class JarSignerCommandLineBuilder {
private static final Logger DEFAULT_LOGGER = new ConsoleLogger(0, JarSignerCommandLineBuilder.class.getName());

private Logger logger = DEFAULT_LOGGER;
private Logger logger = LoggerFactory.getLogger(JarSignerCommandLineBuilder.class);

private String jarSignerFile;

Expand Down