Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-807] Simplify IT for MJAVADOC-498 #309

Closed
wants to merge 1 commit into from
Closed

Conversation

michael-o
Copy link
Member

This closes #309

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

asfgit pushed a commit that referenced this pull request Aug 14, 2024
michael-o added a commit that referenced this pull request Aug 15, 2024
michael-o added a commit that referenced this pull request Aug 15, 2024
michael-o added a commit that referenced this pull request Aug 15, 2024
michael-o added a commit that referenced this pull request Aug 15, 2024
asfgit pushed a commit that referenced this pull request Aug 15, 2024
assert log.count( " --module-path" ) == 3
def count = log.count( " --module-path" )
// depends on Maven version
assert count == 2 || count == 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mavenVersion property defined so we can add something like

assert mavenVersion.startWith('4') && count == x || mavenVersion.startWith('3') && count == y

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me try that. But how to solve before 3.9.x and after? That is a mere string.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is a string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the comment and will leave as-is. Without a selector on an object that is too much fiddling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants