[MJLINK-75] create reproducible zip archive #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
reviewed
Jan 23, 2024
Comment on lines
+527
to
+529
| if (lastModified != null) { | ||
| zipArchiver.configureReproducible(lastModified); | ||
| } |
There was a problem hiding this comment.
Why is the null check needed here, but not in https://github.com/apache/maven-rar-plugin/commit/6ea9c738f089930b5f27b4e7796808412b1886b0/ ?
There was a problem hiding this comment.
because here it's a method for Plexus Archiver, while in maven-rar-plugin it's Maven Archiver (that only works on jars)
| @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File outputDirector | |||
| throws MojoExecutionException { | |||
| zipArchiver.addDirectory(outputDirectoryImage); | |||
|
|
|||
| // configure for Reproducible Builds based on outputTimestamp value | |||
| Date lastModified = new MavenArchiver().parseOutputTimestamp(outputTimestamp); | |||
| if (lastModified != null) { | |||
There was a problem hiding this comment.
Do we also want to add a line similar to this one?
https://github.com/apache/maven-rar-plugin/commit/6ea9c738f089930b5f27b4e7796808412b1886b0/#diff-bb425c248269250f8709b3657272fc04a50a12d316ceb241c1fa64a2c19f9cadR382
There was a problem hiding this comment.
in jlink, it's a zip, not a jar, then there are no MANIFEST.MF metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MJLINK-75