Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jansi native libraries #117

Closed
wants to merge 2 commits into from
Closed

Add jansi native libraries #117

wants to merge 2 commits into from
+71 −4

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Oct 20, 2020

No description provided.

@ppalaga ppalaga mentioned this pull request Oct 20, 2020
Closed
gnodet
gnodet reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really convinced by this commit, since we loose the fact that projects are identified by the projectGA output.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 23, 2020

we loose the fact that projects are identified by the projectGA output.

You mean the logging changes in SmartBuilderImpl? bd69997

The log messages stay the same. The rationale is that the projectGA(project) method does not need to be called if the log level is lower than debug.

For the jansi native libraries commit, I am not 100% sure this is the right approach. In stock Maven the jansi native libs are in lib/jansi-native/* and they are not in jars. We do not include those in our distro and I think we should not as long as we use a different jansi version: 1.17.1 on stock maven vs. 1.8 on our side. Do you have any opinion on that?

The CI failure on Linux is intermittent #102
The failure on Mac seems to be real - would you mind having a look?

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 23, 2020

I have moved the logging change into a separate PR: #134

@gnodet
Copy link
Contributor

gnodet commented Oct 23, 2020

we loose the fact that projects are identified by the projectGA output.

You mean the logging changes in SmartBuilderImpl? bd69997

The log messages stay the same. The rationale is that the projectGA(project) method does not need to be called if the log level is lower than debug.

For the jansi native libraries commit, I am not 100% sure this is the right approach. In stock Maven the jansi native libs are in lib/jansi-native/* and they are not in jars. We do not include those in our distro and I think we should not as long as we use a different jansi version: 1.17.1 on stock maven vs. 1.8 on our side. Do you have any opinion on that?

AFAIK, the main problem is that Jansi does not work when running the natively compiled mvnd. I don't really care if the native libraries are extracted in the distribution or embedded at the moment.
I'm actively working on Jansi to support missing architectures and fixing windows problems.

The CI failure on Linux is intermittent #102
The failure on Mac seems to be real - would you mind having a look?

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 23, 2020

AFAIK, the main problem is that Jansi does not work when running the natively compiled mvnd. I don't really care if the native libraries are extracted in the distribution or embedded at the moment.
I'm actively working on Jansi to support missing architectures and fixing windows problems.

OK, let's close this then

@ppalaga ppalaga closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppalaga @gnodet