Fix #33 Maven mojo change ignored #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
force-pushed
the
33.3
branch
3 times, most recently
from
d670578 to
8b2f67c
Compare
|
@gnodet I ended up with a hybrid: using the TimestampedCacheRecord we had earlier for Mac and a stock JDK WatchService for all other platforms. gmethvin/directory-watcher turned up to be too inflexible for our use case - it does not allow adding and removing watched dirs dynamically. We'd have to build and start it anew on every cache add/removal. |
|
The CI is passing \o/ Could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn 3 using WatchService