Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPLUGINTESTING-94] Switch to Maven 4.0.0-beta-3 #39

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Nov 28, 2023

This PR switches maven-plugin-testing to support plugins based on the Maven 4 API.
Support for maven 3 plugins is removed, as there is no code sharing at all, so it's easier to split both code bases imho.

@gnodet gnodet force-pushed the upgrade-alpha-9 branch 2 times, most recently from cf30a3c to 6ad7848 Compare December 13, 2023 16:02
@gnodet gnodet marked this pull request as ready for review December 13, 2023 19:33
@gnodet gnodet changed the title Upgrade to Maven 4.0.0-alpha-9 Upgrade to Maven 4.0.0-alpha-11 Dec 20, 2023
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Maven 4 artifats in provided scope or optional to allow use library with Maven 3.x also.

@gnodet gnodet changed the title Upgrade to Maven 4.0.0-alpha-11 Upgrade to Maven 4.0.0-alpha-12 Jan 12, 2024
@gnodet gnodet force-pushed the upgrade-alpha-9 branch from 99af984 to fe29e1a Compare March 1, 2024 16:08
@gnodet gnodet force-pushed the upgrade-alpha-9 branch 2 times, most recently from 9ec8f24 to 8ae0c60 Compare May 23, 2024 09:45
@gnodet gnodet changed the title Upgrade to Maven 4.0.0-alpha-12 Upgrade to Maven 4.0.0-alpha-13 May 23, 2024
@gnodet gnodet force-pushed the upgrade-alpha-9 branch 2 times, most recently from 98db829 to 50febee Compare May 23, 2024 13:15
@gnodet gnodet changed the title Upgrade to Maven 4.0.0-alpha-13 Upgrade to Maven 4.0.0-beta-3 Jun 14, 2024
@gnodet gnodet force-pushed the upgrade-alpha-9 branch from 5562804 to 2087cba Compare June 14, 2024 15:16
@gnodet gnodet changed the title Upgrade to Maven 4.0.0-beta-3 [MPLUGINTESTING-94] Switch to Maven 4.0.0-beta-3 Jun 14, 2024
@gnodet gnodet requested a review from slawekjaranowski June 14, 2024 15:17
@gnodet gnodet force-pushed the upgrade-alpha-9 branch from 2087cba to 07b5181 Compare June 17, 2024 08:37
@gnodet
Copy link
Contributor Author

gnodet commented Jun 20, 2024

@slawekjaranowski @cstamas could you have a look at this one ?

@gnodet gnodet merged commit fddd725 into apache:master Jun 21, 2024
14 checks passed
@cstamas
Copy link
Member

cstamas commented Jun 21, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants