Improve JUnit5 extension, make similar to Maven 4 implementation #50
Conversation
aamotharald
changed the title
aamotharald
changed the title
maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing/InjectMojo.java
Show resolved
Hide resolved
|
This is really interesting. |
|
Hi @gnodet , So what's left open is the stubbing. I made a check and backporting all the stubs seems to be a bigger task. My current opinion is to NOT offer the stubs on maven 3 (which means maven-plugin-testing with stubs is only possible with old JUnit 4 style tests extending the AbstractMojoTestCase). What is your opinion there? |
|
Resolve #192 |
|
@aamotharald Same here :) |
slawekjaranowski
force-pushed
the
contribution/MPLUGINTESTING-93
branch
from
c58431e to
4f7af5a
Compare
|
@gnodet @slachiewicz @aamotharald I have rebased and fix build I hope we can process it forward |
| import org.codehaus.plexus.util.xml.Xpp3DomBuilder; | ||
|
|
||
| /** | ||
| * TODO: add a way to use the plugin POM for the lookup so that the user doesn't have to provide the a:g:v:goal |
There was a problem hiding this comment.
That looks slightly weird to add a bunch of TODO and deprecate the class at the same time...
There was a problem hiding this comment.
I will remove TODO from deprecated classes .... 😄
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @MojoTest | ||
| class Junit5Test { |
There was a problem hiding this comment.
Why removing this one ? Is it duplicating another test ?
There was a problem hiding this comment.
we have JUnit5 tests in maven-plugin-testing-harness/src/test/java/org/apache/maven/plugin/testing/ParametersMojoTest.java
# Conflicts: # maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
slawekjaranowski
force-pushed
the
contribution/MPLUGINTESTING-93
branch
from
cfe7813 to
a33ed8d
Compare
|
@gnodet @slachiewicz look ok for me .... I would like to process it I will change PR title as we improve JUnit 5 implementation, documentation will be fixed in next PR @aamotharald thanks for work |
| String basedir = AnnotationSupport.findAnnotation(context.getElement().get(), Basedir.class) | ||
| .map(Basedir::value) | ||
| .orElse(getBasedir()); | ||
| field.set(null, basedir); |
There was a problem hiding this comment.
this will be fixed with:
we should not override a static field
slawekjaranowski
changed the title
slawekjaranowski
merged commit f46bdbe
into
apache:maven-plugin-testing-3.x
6 participants
starting some documentation activities now and performing testing of the JUnit5 maven-plugin testing capabilities with existing open source maven plugins.
@gnodet I have made a small change in the MojoExtension as I think it's valid to have no configuration for your maven plugin at all. I'll just take the commit away if my understanding here is wrong