[MPLUGIN-471] Generated table by PluginXdocGenerator does not contain…

… default attributes
apache · May 12, 2023 · 63a14f7 · 63a14f7
1 parent ca911b2
commit 63a14f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/...generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java b/...generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java
@@ -99,19 +99,15 @@ public PluginXdocGenerator(MavenProject project) {
 
     /**
      * @param project not null.
-     * @param locale  not null wanted locale.
+     * @param locale  not null.
      */
     public PluginXdocGenerator(
             MavenProject project,
             Locale locale,
             File reportOutputDirectory,
             boolean disableInternalJavadocLinkValidation) {
         this.project = project;
-        if (locale == null) {
-            this.locale = Locale.ENGLISH;
-        } else {
-            this.locale = locale;
-        }
+        this.locale = locale;
         this.reportOutputDirectory = reportOutputDirectory;
         this.disableInternalJavadocLinkValidation = disableInternalJavadocLinkValidation;
     }
@@ -446,7 +442,6 @@ private void writeParameterDetails(List<Parameter> parameterList, XMLWriter w, S
 
             w.startElement("div");
             if (StringUtils.isNotEmpty(parameter.getDescription())) {
-
                 w.writeMarkup(getXhtmlWithValidatedLinks(parameter.getDescription(), context));
             } else {
                 w.writeMarkup(getString("pluginxdoc.nodescription"));
@@ -631,6 +626,7 @@ private void writeParameterList(String title, List<Parameter> parameterList, XML
 
         w.startElement("table");
         w.addAttribute("border", "0");
+        w.addAttribute("class", "bodyTable");
 
         w.startElement("tr");
         w.startElement("th");

diff --git a/maven-plugin-tools-generators/src/test/resources/expected-testGoal-mojo.xml b/maven-plugin-tools-generators/src/test/resources/expected-testGoal-mojo.xml
@@ -47,7 +47,7 @@
         </li>
       </ul>
       <subsection name="Required Parameters">
-        <table border="0">
+        <table border="0" class="bodyTable">
           <tr>
             <th>Name</th>
             <th>Type</th>
@@ -81,7 +81,7 @@
         </table>
       </subsection>
       <subsection name="Optional Parameters">
-        <table border="0">
+        <table border="0" class="bodyTable">
           <tr>
             <th>Name</th>
             <th>Type</th>