-
Notifications
You must be signed in to change notification settings - Fork 51
[MPMD-412] Remove unused code and otherwise cleanup tests #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test passes locally. Not sure why it's failing in CI: Error: org.apache.maven.plugins.pmd.CpdViolationCheckMojoTest.testException -- Time elapsed: 0.126 s <<< FAILURE! |
|
Also, all tests do appear to be passing on some of the builds, just not all of them. |
|
Possibly only failing on Windows? Need a windows system to test on |
|
is this still valid PR? |
|
I assume so. I seem to recall this one is hitting some problems on Windows, and I don't have a windows system handy to test |
|
Branch fails for me on Windows 10 |
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL. I've split these changes into several PRs. The changes remaining in this PR no longer trip the issue on Windows.
|
Resolve #379 |
1 similar comment
|
Resolve #379 |
This cleanup revealed bugs in tests including in testInvalidTargetJdk and PmdViolationCheckMojoTest where the tests were incorrectly configured so the wrong exceptions were thrown. That is, the tests were in fact failing but this was hidden by an overly broad catch clause.