Fix failed tests in CPD reports that were hidden by overly broad catch clauses #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
changed the title
Bukama
reviewed
Apr 20, 2025
| } catch (final Exception e) { | ||
| assertTrue(e.getMessage() | ||
| .startsWith("CPD " + AbstractPmdReport.getPmdVersion() + " has found 1 duplication.")); | ||
| } catch (final MojoFailureException e) { |
Contributor
There was a problem hiding this comment.
There are asserts for expections, see https://junit.org/junit5/docs/current/user-guide/#writing-tests-exceptions-expected
elharo
commented
May 1, 2025
Contributor
Author
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
PTAL. Finally figured out got all the tests passing across the matrix
Bukama
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.