Skip to content

#200 [core] Migrate to Java 21 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pankraz76 wants to merge 2 commits into from
Closed

#200 [core] Migrate to Java 21 #201

Pankraz76 wants to merge 2 commits into from

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Apr 30, 2025 •
edited
Loading

#200 [core] Migrate to Java 21

[INFO] BUILD SUCCESS

@Pankraz76 Pankraz76 changed the title #5713 [core] Migrate to Java 21 #200 [core] Migrate to Java 21 Apr 30, 2025
@Pankraz76 Pankraz76 marked this pull request as ready for review April 30, 2025 20:33
This was referenced Apr 30, 2025
Closed
Closed
Closed
@Pankraz76
Copy link
Author

Pankraz76 commented Apr 30, 2025 •
edited
Loading

will release maven-pmd-plugin:4.0.0 - Migrate to Java 21 to be used in:

slachiewicz
slachiewicz reviewed May 2, 2025
View reviewed changes
@slachiewicz
Copy link
Member

slachiewicz commented May 2, 2025

You need also to adjust CI/CD pipeline

Pankraz76
Pankraz76 commented May 2, 2025
View reviewed changes
@Pankraz76
Update pom.xml
6f29921 
apply remove this
@Pankraz76
Copy link
Author

Pankraz76 commented May 2, 2025 •
edited
Loading

You need also to adjust CI/CD pipeline

is it located in this repo, please? where to find this?

@slachiewicz
Copy link
Member

slachiewicz commented May 2, 2025

You need also to adjust CI/CD pipeline

is it located in this repo, please? where to find this?

maven-verify.yaml

Pankraz76 added a commit to Pankraz76/maven-build-cache-extension that referenced this pull request May 3, 2025
@Pankraz76
apache#200 [core] Migrate to Java 21
a590696 
apache/maven-pmd-plugin#201
@Pankraz76 Pankraz76 mentioned this pull request May 3, 2025
Closed
8 tasks
@Pankraz76
Copy link
Author

Pankraz76 commented May 3, 2025

you mean this? https://github.com/apache/maven-pmd-plugin/blob/master/.github/workflows/maven-verify.yml
I did not found any java version in this and googled: apache/maven-build-cache-extension#211
This looks more adjustable.

@slachiewicz
Copy link
Member

slachiewicz commented May 3, 2025

Yes this file. Documentation for our gha can be found here

https://github.com/apache/maven-gh-actions-shared

@michael-o
Copy link
Member

michael-o commented May 3, 2025

@slachiewicz Why are you entertaning this and wasting your time? I'd close it straight away.

@Pankraz76
Copy link
Author

Pankraz76 commented May 3, 2025

yes if not fully agreed upon nor approved efforts should be kept small before investing.

@slachiewicz
Copy link
Member

slachiewicz commented May 4, 2025

@michael-o i don't think that helping contributors to explain how our ci/cd works is wasting my time. Every new energy is valuable to OSS community. Also vote to migrate to Maven 21 was open on user/dev mailing list.

Also OSS recipes like https://docs.openrewrite.org/recipes/java/migrate/upgradetojava21 could see how much work is to migrate to Java 21.

@michael-o
Copy link
Member

michael-o commented May 4, 2025

@michael-o i don't think that helping contributors to explain how our ci/cd works is wasting my time. Every new energy is valuable to OSS community. Also vote to migrate to Maven 21 was open on user/dev mailing list.

Also OSS recipes like https://docs.openrewrite.org/recipes/java/migrate/upgradetojava21 could see how much work is to migrate to Java 21.

The waste of time is trying to migrate this plugin to 21.

@slawekjaranowski
Copy link
Member

slawekjaranowski commented May 5, 2025

The version 3.x of plugin is dedicated to Maven 3.x which is JDK 8 .... so it will still be a JDK 8

First we need to migrate API to Maven 4.x

slawekjaranowski
slawekjaranowski requested changes May 5, 2025
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.x should stay on JDK 8

@Pankraz76 Pankraz76 closed this May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slachiewicz slachiewicz slachiewicz left review comments

@slawekjaranowski slawekjaranowski slawekjaranowski requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pankraz76 @slachiewicz @michael-o @slawekjaranowski