Skip to content

Allow plugin execute with Maven 4 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slawekjaranowski merged 2 commits into from
May 31, 2025
Merged

Allow plugin execute with Maven 4 #209

slawekjaranowski merged 2 commits into from
May 31, 2025

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented May 23, 2025 •
edited
Loading

its fix

  • fix repository url in MPMD-335-aggregate-classpath-repositories
  • skip MPMD-323-ruleset-basedir-jgitver with Maven 4 - looks like problem in jgitver

implentation

remove SLF4J configuration in org.apache.maven.plugins.pmd.exec.Executor

  • intranla clasess from Maven 3 was used
  • logger was used only in two place, in one never used

@slawekjaranowski slawekjaranowski force-pushed the fix-191 branch 2 times, most recently from bce4560 to f3c340a Compare May 23, 2025 20:43
@slawekjaranowski slawekjaranowski marked this pull request as draft May 23, 2025 20:52
@slawekjaranowski slawekjaranowski changed the title Allow building ITs by Maven 4 Allow plugin execute with Maven 4 May 30, 2025
@slawekjaranowski slawekjaranowski marked this pull request as ready for review May 30, 2025 18:18
@slawekjaranowski slawekjaranowski self-assigned this May 30, 2025
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label May 30, 2025
@slawekjaranowski slawekjaranowski linked an issue May 30, 2025 that may be closed by this pull request
IT "MPMD-335-aggregate-classpath-repositories" not compatible with Maven 4 #191
Closed
@slawekjaranowski slawekjaranowski merged commit 2954317 into apache:master May 31, 2025
26 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-191 branch May 31, 2025 07:22
@github-actions github-actions bot added this to the 3.26.1 milestone May 31, 2025
@yagee-de yagee-de mentioned this pull request Jun 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstamas cstamas cstamas approved these changes

@gnodet gnodet gnodet approved these changes

@adangel adangel Awaiting requested review from adangel

Assignees

@slawekjaranowski slawekjaranowski

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.27.0

Development

Successfully merging this pull request may close these issues.

IT "MPMD-335-aggregate-classpath-repositories" not compatible with Maven 4

3 participants

@slawekjaranowski @cstamas @gnodet