-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPMD-304] - maven-pmd-plugin should be toolchains-aware #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step: Separating the execution of PMD into a separate class. See PmdExecutor and PmdRequest.
Further refactoring. Resolve deprecated usages.
Add CpdExecutor, CpdRequest, CpdResult
Further refactoring
Add toolchain support for PMD
Add integration test
Add toolchain support for CPD
Add short documentation
…xml" This reverts commit 8f2bff9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds toolchain support for PMD and CPD (see https://issues.apache.org/jira/browse/MPMD-304).
In order to do this, the following changes are made:
target/pmd.xml
andtarget/cpd.xml
files. So basically, PMD serializeds the result into these XML files, and m-pmd-p picks it up from there.There are two possible incompatibilities:
PmdReport.getPMDConfiguration()
is gone - the PMDConfiguration instance is created now by PmdExecutor and is not exposed anymore.PmdReportGenerator
andCpdReportGenerator
now work with the classes generated by m-pmd-p's generated modello classes instead of the PMD classes.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MPMD-XXX] - Subject of the JIRA Ticket
,where you replace
MPMD-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.