Skip to content

Commit

Permalink
Improve variable name
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-o committed Jun 22, 2024
1 parent 1231c79 commit b08af0c
Showing 1 changed file with 16 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -550,13 +550,13 @@ private void renderSectionDependencyFileDetails() {

if (JAR_SUBTYPE.contains(artifact.getType().toLowerCase())) {
try {
JarData jarDetails = dependencies.getJarDependencyDetails(artifact);
JarData jarData = dependencies.getJarDependencyDetails(artifact);

totalentries.addTotal(jarDetails.getNumEntries(), artifact.getScope());
totalclasses.addTotal(jarDetails.getNumClasses(), artifact.getScope());
totalpackages.addTotal(jarDetails.getNumPackages(), artifact.getScope());
totalentries.addTotal(jarData.getNumEntries(), artifact.getScope());
totalclasses.addTotal(jarData.getNumClasses(), artifact.getScope());
totalpackages.addTotal(jarData.getNumPackages(), artifact.getScope());

String jdkRevisionCellValue = jarDetails.getJdkRevision();
String jdkRevisionCellValue = jarData.getJdkRevision();
String debugInformationCellValue = null;
String sealedCellValue = null;

Expand All @@ -574,13 +574,13 @@ private void renderSectionDependencyFileDetails() {
}

debugInformationCellValue = debugInformationCellNo;
if (jarDetails.isDebugPresent()) {
if (jarData.isDebugPresent()) {
debugInformationCellValue = debugInformationCellYes;
totalDebugInformation.incrementTotal(artifact.getScope());
}

sealedCellValue = sealedCellNo;
if (jarDetails.isSealed()) {
if (jarData.isSealed()) {
sealedCellValue = sealedCellYes;
totalsealed.incrementTotal(artifact.getScope());
}
Expand All @@ -595,24 +595,17 @@ private void renderSectionDependencyFileDetails() {
fileLength = "-";
}

if (jarDetails.isMultiRelease()) {
if (jarData.isMultiRelease()) {
String htmlBullet = "   • ";
String rootTag = htmlBullet + getI18nString("file.details.multirelease.root");
String versionedTag = htmlBullet + getI18nString("file.details.multirelease.versioned");

// general jar information row
tableRow(hasSealed, new String[] {
name,
fileLength,
String.valueOf(jarDetails.getNumEntries()),
"",
"",
"",
"",
sealedCellValue
name, fileLength, String.valueOf(jarData.getNumEntries()), "", "", "", "", sealedCellValue
});

JarVersionedRuntimes versionedRuntimes = jarDetails.getVersionedRuntimes();
JarVersionedRuntimes versionedRuntimes = jarData.getVersionedRuntimes();
Collection<JarVersionedRuntime> versionedRuntimeList =
versionedRuntimes.getVersionedRuntimeMap().values();

Expand All @@ -622,15 +615,15 @@ private void renderSectionDependencyFileDetails() {
.map(versionedRuntime ->
versionedRuntime.getEntries().size())
.reduce(0, Integer::sum);
Integer rootContentNumEntries = jarDetails.getNumEntries() - versionedNumEntries;
Integer rootContentNumEntries = jarData.getNumEntries() - versionedNumEntries;

// root content information row
tableRow(hasSealed, new String[] {
rootTag,
"",
String.valueOf(rootContentNumEntries),
String.valueOf(jarDetails.getNumClasses()),
String.valueOf(jarDetails.getNumPackages()),
String.valueOf(jarData.getNumClasses()),
String.valueOf(jarData.getNumPackages()),
jdkRevisionCellValue,
debugInformationCellValue,
""
Expand All @@ -657,9 +650,9 @@ private void renderSectionDependencyFileDetails() {
tableRow(hasSealed, new String[] {
name,
fileLength,
String.valueOf(jarDetails.getNumEntries()),
String.valueOf(jarDetails.getNumClasses()),
String.valueOf(jarDetails.getNumPackages()),
String.valueOf(jarData.getNumEntries()),
String.valueOf(jarData.getNumClasses()),
String.valueOf(jarData.getNumPackages()),
jdkRevisionCellValue,
debugInformationCellValue,
sealedCellValue
Expand Down

0 comments on commit b08af0c

Please sign in to comment.