[MRRESOURCES-126] Get rid of legacy #26

cstamas · 2023-03-06T14:18:51Z

Get rid of MAT, Maven 3.9.1 warning about localRepository, etc. Make Maven resolve and not Mojo, this gets rid of quite a lot code. For runOnlyAtExecutionRoot introduce new mojo aggregate-process that is aggregator Mojo.

So, with this PR:

the existing process mojo does all as before, but is much simpler, but LOOSES runOnlyAtExecutionRoot parameter and functionality
added new aggregator-process Mojo that does what process w/ runOnlyAtExecutionRoot before did with slight changes (in bulk output, that is IMHO acceptable).

https://issues.apache.org/jira/browse/MRRESOURCES-126

And with 3.9.0 suddenly all the ITs suffer from "change packaging to pom" error.

pom.xml

src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java

src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

Plain and an aggregator

src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java

elharo

Sounds like a good idea. It should be a major version bump in the plugin's own version.

go back to good ol' stinky mojo logger and replace vs replaceAll

cstamas · 2023-03-24T08:54:56Z

Ran maven 3.9,.x build (w/ currently used MRR plugin, then with 3.1.0-SNAPSHOT), diffed outputs:

[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/DEPENDENCIES ~/tmp/mrrp/original/compat/DEPENDENCIES 
76,79d53
< 
<   - Maven Compat (https://maven.apache.org/ref/3.9.2-SNAPSHOT/maven-compat/) org.apache.maven:maven-compat:jar:3.9.2-SNAPSHOT
<     License: Apache-2.0  (https://www.apache.org/licenses/LICENSE-2.0.txt)
< 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/LICENSE ~/tmp/mrrp/original/compat/LICENSE 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/NOTICE ~/tmp/mrrp/original/compat/NOTICE 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/DEPENDENCIES ~/tmp/mrrp/original/core/DEPENDENCIES 
76,79d53
< 
<   - Maven Core (https://maven.apache.org/ref/3.9.2-SNAPSHOT/maven-core/) org.apache.maven:maven-core:jar:3.9.2-SNAPSHOT
<     License: Apache-2.0  (https://www.apache.org/licenses/LICENSE-2.0.txt)
< 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/LICENSE ~/tmp/mrrp/original/core/LICENSE
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/NOTICE ~/tmp/mrrp/original/core/NOTICE 
[cstamas@urnebes maven (maven-3.9.x *)]$

Seems in LICENSES the plugin now includes "itself" as well?
And finally, the warnings are gone as well...

cstamas · 2023-03-24T09:05:46Z

Last commit fixes:

[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/DEPENDENCIES ~/tmp/mrrp/original/compat/DEPENDENCIES 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/LICENSE ~/tmp/mrrp/original/compat/LICENSE 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-compat/target/classes/META-INF/NOTICE ~/tmp/mrrp/original/compat/NOTICE 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/DEPENDENCIES ~/tmp/mrrp/original/core/DEPENDENCIES 
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/LICENSE ~/tmp/mrrp/original/core/LICENSE
[cstamas@urnebes maven (maven-3.9.x *)]$ diff -wB maven-core/target/classes/META-INF/NOTICE ~/tmp/mrrp/original/core/NOTICE 
[cstamas@urnebes maven (maven-3.9.x *)]$

So, in Maven 3.9.x build this PR now produces same (sans some extra newlines, I guess due templates?) output as currently used 1.7.0 plugin.

elharo · 2023-03-24T10:54:31Z

src/it/resources/run-only-at-execution-root/pom.xml

            </goals>
            <configuration>
-              <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>
+<!--              <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>-->


Maybe I'm misunderstanding this. Was the runOnlyAtExecutionRoot parameter removed, made a no-op, or still exists in a different plugin but is no longer needed here?

My concern is whether this change requires dependents to update their own POMs or not.

The runOnlyAtExecutionRoot has been removed. But for maven plugin, this is same as no-op as build will not break even if present. Maybe we need to break the build and redirect users to new mojo?

See https://lists.apache.org/thread/bhtozf6w2nknvfzbfc1jb76fr6rqpkbx

The truth is, that this plugin was made for ASF purposes, am unsure is anyone outside ASF using it... so this is not a "general public" plugin like compiler or assembly plugin is...

The new goal name should be logically identically to other plugins: "aggregate" at beginning or end:

osipovmi@deblndw011x:~/var/Projekte/maven-sources (submodules =) $ grep -r --include='*.java' -- '-aggregate"' . ./plugins/reporting/jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AggregatorJxrTestReport.java:@Mojo( name = "test-aggregate", aggregator = true ) ./plugins/reporting/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleAggregateReport.java:@Mojo( name = "checkstyle-aggregate", aggregator = true, requiresDependencyResolution = ResolutionScope.COMPILE, ./plugins/reporting/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleAggregateReport.java: return "checkstyle-aggregate"; ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorTestJavadocReport.java:@Mojo( name = "test-aggregate", aggregator = true, requiresDependencyResolution = ResolutionScope.TEST ) ./plugins/tools/maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/PdfAggregateMojo.java: @Parameter( defaultValue = "${project.build.directory}/pdf-aggregate", required = true ) ./plugins/tools/maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/PdfAggregateMojo.java: @Parameter( defaultValue = "${project.build.directory}/pdf-aggregate", required = true ) osipovmi@deblndw011x:~/var/Projekte/maven-sources (submodules =) $ grep -r --include='*.java' '"aggregate-' . ./plugins/reporting/jxr/maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/stubs/AggregateSubmodule1MavenProjectStub.java: setArtifactId( "aggregate-test-submodule1" ); ./plugins/reporting/jxr/maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/stubs/AggregateSubmodule2MavenProjectStub.java: setArtifactId( "aggregate-test-submodule2" ); ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorJavadocJar.java:@Mojo( name = "aggregate-jar", defaultPhase = LifecyclePhase.PACKAGE, aggregator = true, ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorJavadocNoForkReport.java:@Mojo( name = "aggregate-no-fork", requiresDependencyResolution = ResolutionScope.COMPILE ) ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-test/aggregate-test-plugin-config.xml" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-resources-test/aggregate-resources-test-plugin-config.xml" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-modules-not-in-subfolders-test/all/pom.xml"); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject1TestMavenProjectStub.java: setArtifactId( "aggregate-test-project1" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject1TestMavenProjectStub.java: build.setFinalName( "aggregate-test-project1" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject2TestMavenProjectStub.java: setArtifactId( "aggregate-test-project2" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject2TestMavenProjectStub.java: build.setFinalName( "aggregate-test-project2" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateResourcesTestMavenProjectStub.java: "aggregate-resources-test-plugin-config.xml", ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateTestMavenProjectStub.java: readModel( new File( getBasedir(), "aggregate-test-plugin-config.xml" ) ); ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdReport.java:@Mojo( name = "aggregate-cpd", aggregator = true, threadSafe = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdViolationCheckMojo.java:@Mojo( name = "aggregate-cpd-check", defaultPhase = LifecyclePhase.VERIFY, threadSafe = true, aggregator = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdViolationCheckMojo.java:@Execute( goal = "aggregate-cpd" ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdNoForkReport.java:@Mojo( name = "aggregate-pmd-no-fork", aggregator = true, threadSafe = true, ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdReport.java:@Mojo( name = "aggregate-pmd", aggregator = true, threadSafe = true, ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdViolationCheckMojo.java:@Mojo( name = "aggregate-pmd-check", defaultPhase = LifecyclePhase.VERIFY, aggregator = true, threadSafe = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdViolationCheckMojo.java:@Execute( goal = "aggregate-pmd" )

pom.xml

michael-o · 2023-03-25T09:47:30Z

src/it/resources/run-only-at-execution-root/pom.xml

            </goals>
            <configuration>
-              <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>
+<!--              <runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>-->


The new goal name should be logically identically to other plugins: "aggregate" at beginning or end:

osipovmi@deblndw011x:~/var/Projekte/maven-sources (submodules =) $ grep -r --include='*.java' -- '-aggregate"' . ./plugins/reporting/jxr/maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AggregatorJxrTestReport.java:@Mojo( name = "test-aggregate", aggregator = true ) ./plugins/reporting/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleAggregateReport.java:@Mojo( name = "checkstyle-aggregate", aggregator = true, requiresDependencyResolution = ResolutionScope.COMPILE, ./plugins/reporting/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleAggregateReport.java: return "checkstyle-aggregate"; ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorTestJavadocReport.java:@Mojo( name = "test-aggregate", aggregator = true, requiresDependencyResolution = ResolutionScope.TEST ) ./plugins/tools/maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/PdfAggregateMojo.java: @Parameter( defaultValue = "${project.build.directory}/pdf-aggregate", required = true ) ./plugins/tools/maven-pdf-plugin/src/main/java/org/apache/maven/plugins/pdf/PdfAggregateMojo.java: @Parameter( defaultValue = "${project.build.directory}/pdf-aggregate", required = true ) osipovmi@deblndw011x:~/var/Projekte/maven-sources (submodules =) $ grep -r --include='*.java' '"aggregate-' . ./plugins/reporting/jxr/maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/stubs/AggregateSubmodule1MavenProjectStub.java: setArtifactId( "aggregate-test-submodule1" ); ./plugins/reporting/jxr/maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/stubs/AggregateSubmodule2MavenProjectStub.java: setArtifactId( "aggregate-test-submodule2" ); ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorJavadocJar.java:@Mojo( name = "aggregate-jar", defaultPhase = LifecyclePhase.PACKAGE, aggregator = true, ./plugins/reporting/maven-javadoc-plugin/src/main/java/org/apache/maven/plugins/javadoc/AggregatorJavadocNoForkReport.java:@Mojo( name = "aggregate-no-fork", requiresDependencyResolution = ResolutionScope.COMPILE ) ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-test/aggregate-test-plugin-config.xml" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-resources-test/aggregate-resources-test-plugin-config.xml" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java: File testPom = new File( unit, "aggregate-modules-not-in-subfolders-test/all/pom.xml"); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject1TestMavenProjectStub.java: setArtifactId( "aggregate-test-project1" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject1TestMavenProjectStub.java: build.setFinalName( "aggregate-test-project1" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject2TestMavenProjectStub.java: setArtifactId( "aggregate-test-project2" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateProject2TestMavenProjectStub.java: build.setFinalName( "aggregate-test-project2" ); ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateResourcesTestMavenProjectStub.java: "aggregate-resources-test-plugin-config.xml", ./plugins/reporting/maven-javadoc-plugin/src/test/java/org/apache/maven/plugins/javadoc/stubs/AggregateTestMavenProjectStub.java: readModel( new File( getBasedir(), "aggregate-test-plugin-config.xml" ) ); ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdReport.java:@Mojo( name = "aggregate-cpd", aggregator = true, threadSafe = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdViolationCheckMojo.java:@Mojo( name = "aggregate-cpd-check", defaultPhase = LifecyclePhase.VERIFY, threadSafe = true, aggregator = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorCpdViolationCheckMojo.java:@Execute( goal = "aggregate-cpd" ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdNoForkReport.java:@Mojo( name = "aggregate-pmd-no-fork", aggregator = true, threadSafe = true, ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdReport.java:@Mojo( name = "aggregate-pmd", aggregator = true, threadSafe = true, ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdViolationCheckMojo.java:@Mojo( name = "aggregate-pmd-check", defaultPhase = LifecyclePhase.VERIFY, aggregator = true, threadSafe = true ) ./plugins/reporting/maven-pmd-plugin/src/main/java/org/apache/maven/plugins/pmd/AggregatorPmdViolationCheckMojo.java:@Execute( goal = "aggregate-pmd" )

src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

michael-o · 2023-03-25T09:57:22Z

...main/java/org/apache/maven/plugin/resources/remote/AggregatorProcessRemoteResourcesMojo.java

+       aggregator = true,
+       requiresDependencyResolution = ResolutionScope.TEST,
+       threadSafe = true )
+public class AggregatorProcessRemoteResourcesMojo


See my precending comment regarding naming

kwin · 2023-04-15T13:23:55Z

This is one of the last plugins referenced in ASF parent pom whose latest release version still leads to a WARN with Maven 3.9.x. Therefore it would be nice to soon merge, release and then update in ASF parent.

slawekjaranowski · 2023-04-18T20:47:22Z

Conflict resolved.

Tested with m-dependency-p, looks better

diff -wB target/classes/META-INF/DEPENDENCIES target-2/classes/META-INF/DEPENDENCIES 
37,43d29
< 
<   - Plexus Classworlds (http://plexus.codehaus.org/plexus-classworlds/) org.codehaus.plexus:plexus-classworlds:bundle:2.5.2
<     License: The Apache Software License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
< 
<   - Plexus :: Component Annotations (http://plexus.codehaus.org/plexus-containers/plexus-component-annotations/) org.codehaus.plexus:plexus-component-annotations:jar:1.5.5
<     License: The Apache Software License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
< 
51c36,39
< 
---
>   - Plexus Classworlds (http://codehaus-plexus.github.io/plexus-classworlds/) org.codehaus.plexus:plexus-classworlds:bundle:2.6.0
>     License: Apache License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
>   - Plexus :: Component Annotations (http://codehaus-plexus.github.io/plexus-containers/plexus-component-annotations/) org.codehaus.plexus:plexus-component-annotations:jar:2.0.0
>     License: Apache License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
103,106d74
<   - Logging (http://jakarta.apache.org/commons/${pom.artifactId.substring(8)}/) commons-logging:commons-logging:jar:1.1
<     License: The Apache Software License, Version 2.0  (/LICENSE.txt)
< 
< 
114,117d79
< 
<   - Commons Codec (http://commons.apache.org/codec/) commons-codec:commons-codec:jar:1.6
<     License: The Apache Software License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
< 
123c84,85
< 
---
>   - Apache Commons Logging (http://commons.apache.org/proper/commons-logging/) commons-logging:commons-logging:jar:1.2
>     License: The Apache Software License, Version 2.0  (http://www.apache.org/licenses/LICENSE-2.0.txt)
135c94,95
< 
---
>   - Apache Commons Codec (http://commons.apache.org/proper/commons-codec/) commons-codec:commons-codec:jar:1.11
>     License: Apache License, Version 2.0  (https://www.apache.org/licenses/LICENSE-2.0.txt)

Artifacts used by project are listed

slawekjaranowski · 2023-04-18T22:11:52Z

As I see discussion here is about:

what version will be next
what name of goal should be

can we take such simple decision?

I hope gola name like aggregate-process will be ok - @michael-o ?

michael-o · 2023-04-20T19:17:14Z

As I see discussion here is about:
* what version will be next

* what name of goal should be
can we take such simple decision?

I hope gola name like aggregate-process will be ok - @michael-o ?

I guess so.

slawekjaranowski · 2023-04-22T08:53:16Z

Goal aggregator-process renamed to aggregate

But I see one more issue runOnlyAtExecutionRoot != aggregate goal
We need add <inherited>false</inherited> to configuration

Get rid of legacy

596e848

And with 3.9.0 suddenly all the ITs suffer from "change packaging to pom" error.

cstamas self-assigned this Mar 6, 2023

cstamas added 3 commits March 8, 2023 20:14

WIP

c384ccf

Fix IT project

352812a

Drop unused

64338d3

cstamas requested review from slawekjaranowski, gnodet and michael-o March 8, 2023 19:28

cstamas changed the title ~~Get rid of legacy~~ [MRRESOURCES-126] Get rid of legacy Mar 8, 2023

WIP

8a43f1c

michael-o requested changes Mar 8, 2023

View reviewed changes

pom.xml Show resolved Hide resolved

src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java Outdated Show resolved Hide resolved

cstamas added 3 commits March 9, 2023 12:20

WIP

c2736b3

Remove some unused

9e4ea32

Logging

1bc82f5

michael-o reviewed Mar 9, 2023

View reviewed changes

src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java Outdated Show resolved Hide resolved

Split Mojo in two

c277dcf

Plain and an aggregator

gnodet requested changes Mar 9, 2023

View reviewed changes

cstamas added 3 commits March 9, 2023 15:20

PR comment

801e545

Fix aggregator

9b15157

Javadoc

cb57c46

elharo requested changes Mar 10, 2023

View reviewed changes

cstamas added 2 commits March 24, 2023 09:15

Merge remote-tracking branch 'origin/master' into get-rid-of-legacy

755f795

PR comments

7ce64fa

go back to good ol' stinky mojo logger and replace vs replaceAll

michael-o self-requested a review March 24, 2023 08:46

Do not include yourself

f4a9d45

elharo reviewed Mar 24, 2023

View reviewed changes

slachiewicz reviewed Mar 25, 2023

View reviewed changes

pom.xml Show resolved Hide resolved

michael-o requested changes Mar 25, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into get-rid-of-legacy

9050d68

rename repositorySystem field to repoSystem

a34a796

Rename goal aggregator-process to aggregate

cb3975c

slawekjaranowski approved these changes Apr 30, 2023

View reviewed changes

slawekjaranowski requested review from elharo, gnodet and michael-o April 30, 2023 21:18

slachiewicz approved these changes Apr 30, 2023

View reviewed changes

michael-o approved these changes Apr 30, 2023

View reviewed changes

slawekjaranowski merged commit 6fe5413 into master May 3, 2023

slawekjaranowski deleted the get-rid-of-legacy branch May 3, 2023 12:53

slawekjaranowski added the enhancement label May 3, 2023

slawekjaranowski mentioned this pull request May 7, 2023

[MRRESOURCES-134] Introduce aggregate goal instead of runOnlyAtExecutionRoot parameter #37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRRESOURCES-126] Get rid of legacy #26

[MRRESOURCES-126] Get rid of legacy #26

cstamas commented Mar 6, 2023 •

edited

Loading

elharo left a comment

cstamas commented Mar 24, 2023 •

edited

Loading

cstamas commented Mar 24, 2023 •

edited

Loading

elharo Mar 24, 2023

cstamas Mar 24, 2023

michael-o Mar 25, 2023

michael-o Mar 25, 2023

michael-o Mar 25, 2023

kwin commented Apr 15, 2023

slawekjaranowski commented Apr 18, 2023

slawekjaranowski commented Apr 18, 2023

michael-o commented Apr 20, 2023

slawekjaranowski commented Apr 22, 2023

[MRRESOURCES-126] Get rid of legacy #26

[MRRESOURCES-126] Get rid of legacy #26

Conversation

cstamas commented Mar 6, 2023 • edited Loading

elharo left a comment

Choose a reason for hiding this comment

cstamas commented Mar 24, 2023 • edited Loading

cstamas commented Mar 24, 2023 • edited Loading

elharo Mar 24, 2023

Choose a reason for hiding this comment

cstamas Mar 24, 2023

Choose a reason for hiding this comment

michael-o Mar 25, 2023

Choose a reason for hiding this comment

michael-o Mar 25, 2023

Choose a reason for hiding this comment

michael-o Mar 25, 2023

Choose a reason for hiding this comment

kwin commented Apr 15, 2023

slawekjaranowski commented Apr 18, 2023

slawekjaranowski commented Apr 18, 2023

michael-o commented Apr 20, 2023

slawekjaranowski commented Apr 22, 2023

cstamas commented Mar 6, 2023 •

edited

Loading

cstamas commented Mar 24, 2023 •

edited

Loading

cstamas commented Mar 24, 2023 •

edited

Loading