[MRESOLVER-153] Move out from ResolveTask read/writes #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move out from ResolveTask the read/write of resolver-status.properties file, perform those serially in caller thread context instead.
michael-o
reviewed
May 3, 2021
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Testing this...
I think in the next step this can be rewritten like in DefaultArtifactResolver to get rid of double concurrency.
| session.getLocalRepositoryManager().getPathForRemoteMetadata( | ||
| metadata, request.getRepository(), request.getRequestContext() ) ); | ||
|
|
||
| metadataDownloading( |
Member
There was a problem hiding this comment.
Maybe this could appear later, but doesn't really matter for the moment.
asfgit
pushed a commit
that referenced
this pull request
May 4, 2021
…k to DefaultMetadataResolver Move out from ResolveTask the read/write of resolver-status.properties file, perform those serially in caller thread context instead. This closes #104
asfgit
pushed a commit
that referenced
this pull request
May 4, 2021
…k to DefaultMetadataResolver Move out from ResolveTask the read/write of resolver-status.properties file, perform those serially in caller thread context instead. This closes #104
|
Resolve #925 |
1 similar comment
|
Resolve #925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MRESOLVER-153
Move out from ResolveTask the read/write of resolver-status.properties
file, perform those serially in caller thread context instead.