Bug: Reproducer and fix for #1583 #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cycle is among winner nodes. Created UT as reproducer but we will need more.
Created UT that reproduces: classic CR passes ok, but path CR fails, leave cycle in.
slawekjaranowski
approved these changes
Sep 14, 2025
As other nodes will be marked as losers anyway (and probably eliminated)
Original code LEFT OUT some nodes from Path graph, hence implicitly left cycles in as well (as Path graph was unaware of it). Now we make sure all cycle starting nodes are added as well, AND we make sure they are always "claimed" (winner or loser) as then the DN graph is adjusted properly.
slawekjaranowski
approved these changes
Sep 16, 2025
Member
slawekjaranowski
left a comment
slawekjaranowski
left a comment
There was a problem hiding this comment.
checked with enforcer, dependency and mojo version plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "path" CR in certain cases (cycle involving two different instances of
DependencyNodeas one was managed into same as other + parent of the cycle node has multiple/mixed children of cycling and non cycling + parent of the cycle head was the sole winner) left cycles in place even at verbosity levels ofNONEandSTANDARDwhen cycles should be removed. This is fixed. Another issue was that "path" CR was "too eager" by applying winner scope/optional to all nodes, while it should have apply it only to winner, as losers are marked as such (and possibly eliminated).Changes:
push(int)method as it had some redundancy and misplaced commentsVerbosityjavadoc re loopsrun-its, so is an extra safety beltFixes #1583