Stop proliferation of static helper IO methods #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originall, the PathProcessor (before FileProcessor) was main component dealing with IO, restore this state. The proliferation of static IO helpers is just bad, as it does not allow (easy) overriding as it is the case of components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the
PathProcessor(before the now deprecatedFileProcessor) was main component dealing with IO, restore this state.The proliferation of static IO helpers is just bad, as it does not allow (easy) overriding as it is the case of components.
This fixes another pain point: the component interface
PathProcessor(defined in SPI) has to have two (identical, almost) implementations: one in test-utils and one in impl. Stop this madness as well, now one "support" class is provided that implements everything and is published as component in SPI, but allows simple reusability in tests as well. And, same code is being tested finally.