[MRESOLVER-390] Customize graph visiting strategy #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally it was always preOrder w/ possibility to change. Introduced config and code to support: * "preOrder" -- as before * "postOrder" -- unsure who want this * "levelOrder" -- as asked by users, artifact list is ordered by their level (distance from root) --- https://issues.apache.org/jira/browse/MRESOLVER-390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolver (and thus Maven) had "wired in" strategy to flatten dependency graph into list, and it was always "preOrder", while there existed alternate solutions like "postOrder". This PR introduces "levelOrder" as asked by users, and also makes it configurable (via session config) which strategy should be used, and exposes helper classes and methods.
This PR introduces new visitors that are able to perform the 3 visiting strategies and uses them, while the old ones are left in place (for binary compatibility) but are NOT used in Resolver and their use is discouraged.
Now session can be configured to use following strategies to flatten the graph:
By default, this PR introduces NO behavior changes, but opens configuration that does allow to alter these.
https://issues.apache.org/jira/browse/MRESOLVER-390