[MRESOLVER-324] Make bf option as default #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to branch off 1.9.x first, then master made into 2.0.0... |
michael-o
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it is appropriate time to apply for making bf as default option. At least it is chance to open this PR and started the discussion flow.
There were already some comments in the MRESOLVER-324 and MRESOLVER-7. The performance improvements is significant. And more and more users are adopting this option, at least eBay and @jhaber's company are widely adopting this option and no bigs issues found so far.
Meanwhile microsoft vscode has enabled this option by default since 0.9.0, one issue reported, however this issue only happens when relocation + version range case and was already fixed here by @cstamas .
Also there are some discussions about parallel downloading in stackoverflow.
@michael-o @cstamas Please share your concerns here.