Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tame bnd plugin warnings #525

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Tame bnd plugin warnings #525

merged 2 commits into from
Jul 1, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jul 1, 2024

To keep things simple, we config the plugin in
one place, but in some modules this config emits
warnings. This change just makes it go away.

No other source or any alike change, no issue either.

To keep things simple, we config the plugin in
one place, but in some modules this config emits
warnings. This change just makes it go away.

No other source or any alike change, no issue either.
@cstamas cstamas requested a review from gnodet July 1, 2024 15:02
@cstamas cstamas self-assigned this Jul 1, 2024
@cstamas
Copy link
Member Author

cstamas commented Jul 1, 2024

On master another warning in util and spi:

[WARNING] /home/cstamas/Worx/apache-maven/maven-resolver/maven-resolver-util/pom.xml [17:74]: No value specified for key: -jpms-module-info. An empty value should be specified as '-jpms-module-info:' or '-jpms-module-info=': <<              -jpms-module-info
      -removeheaders Automatic-Module-Name>>

Fix instructions to use same syntax
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've slightly updated the instructions

@HannesWell
Copy link
Contributor

On master another warning in util and spi:

Had a quick look, but according to the doc the module name is looked up if not specified:
https://bnd.bndtools.org/releases/6.4.0/chapters/330-jpms.html

So it might be a bug, that the validation in bnd does not handle that case.

@cstamas cstamas merged commit 19a3c52 into apache:master Jul 1, 2024
5 checks passed
@cstamas cstamas deleted the tame-bnd branch July 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants