[MRESOLVER-612] Align timeout interpretations across HTTP transports #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ConfigurationProperties#REQUEST_TIMEOUT` was wrongly interpreted by JDK and Jetty clients as "absolute max duration of HTTP request". Also, up default CONNECT_TIMEOUT from 10sec to 30sec.
gnodet
requested changes
Oct 23, 2024
| @@ -288,16 +288,20 @@ final class ApacheTransporter extends AbstractTransporter implements HttpTranspo | |||
| .register(AuthSchemes.KERBEROS, new KerberosSchemeFactory()) | |||
| .build(); | |||
| SocketConfig socketConfig = | |||
| SocketConfig.custom().setSoTimeout(requestTimeout).build(); | |||
| // the time to establish connection (low level) | |||
| SocketConfig.custom().setSoTimeout(connectTimeout).build(); | |||
There was a problem hiding this comment.
SO timeout is the read timeout on the socket, so the maximum amount of time between two packets (or, on the server side, the max time for accept()). So I don't think it should be set to connectTimeout.
How does this timeout work wrt to the socket timeout below ? Is the timeout on the SocketConfig used when no value is set on RequestConfig ?
There was a problem hiding this comment.
SoTimeout is set on socket directly (so it works as Javadoc and you explain). The "socket timeout" is specific to HttpClient and would like to get some clarification about it @michael-o
gnodet
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigurationProperties#REQUEST_TIMEOUTwas wrongly interpreted by JDK and Jetty clients as "absolute max duration of HTTP request".Also, up default CONNECT_TIMEOUT from 10sec to 30sec.
Changes per transport:
https://issues.apache.org/jira/browse/MRESOLVER-612
https://issues.apache.org/jira/browse/MRESOLVER-615