-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRESOLVER-627] Improve transport selection and logging #599
Conversation
In previous releases transport selection was really secretive and broken, as it considered invalid configuration as "protocol not supported" and Resolver did not log anything or worse, silently skipped to new transport. --- https://issues.apache.org/jira/browse/MRESOLVER-627
But before all exceptions were blanketed by NoTransporterEx, now we throw RuntimeEx as well when misconfigured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion on this.
Sure, no problem. But let me explain what was initial cause for this PR: Basically, turned out my config had wrong value (a typo), and even Hence, this PR now:
|
In case of runtime ex, it is "transport configuration" issue while in all other cases it is "plain" issue (ie no transporter for protocol).
All those that use prioritized components.
In previous releases transport selection was really secretive and broken, as it considered invalid configuration as "protocol not supported" and Resolver did not log anything or worse, silently skipped to new transport.
Changes:
https://issues.apache.org/jira/browse/MRESOLVER-627