Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8578]add exclusion scope to repo, allow exclude dependencies from build(including parent, dependencies, etc) #654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MNG-8578]add exclusion scope to repo, allow exclude dependencies from build(including parent, dependencies, etc) #654

wants to merge 1 commit into from

Conversation

XenoAmess
Copy link

No description provided.

@XenoAmess
[MNG-8578]add exclusion scope to repo, allow exclude dependencies fro…
240cc04 
…m build(including parent, dependencies, etc)
@XenoAmess XenoAmess force-pushed the feature-add-exclusion-scope-to-repo branch from 59e7fcb to 240cc04 Compare February 12, 2025 01:30
@XenoAmess XenoAmess changed the title add exclusions support for collect request [MNG-8578]add exclusion scope to repo, allow exclude dependencies from build(including parent, dependencies, etc) Feb 12, 2025
@XenoAmess XenoAmess mentioned this pull request Feb 12, 2025
Open
9 tasks
elharo
elharo requested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have docs, both a proposal explaining what you want to do and docs for the end user if it's merged.

elharo
elharo requested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also requires tests, and those should be written before the model code is written, not after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XenoAmess @elharo