Skip to content

Commit

Permalink
[SCM-1024] maven-scm-plugin tests do not properly check for existence…
Browse files Browse the repository at this point in the history
… of svn command

This closes #205
  • Loading branch information
michael-o committed Apr 7, 2024
1 parent 17a44f9 commit 93d0142
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

try {
def proc = "svn".execute()
proc.consumeProcessOutput()
proc.waitFor()
} catch (IOException e) {
return false
}
26 changes: 26 additions & 0 deletions maven-scm-plugin/src/it/scm-781/selector.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

try {
def proc = "svn".execute()
proc.consumeProcessOutput()
proc.waitFor()
} catch (IOException e) {
return false
}
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ public void testChangeLogWithBadUserDateFormat() throws Exception {
}

public void testChangeLogWithBadConnectionUrl() throws Exception {
if (!ScmTestCase.isSystemCmd(SvnScmTestUtils.SVN_COMMAND_LINE)) {
ScmTestCase.printSystemCmdUnavail(SvnScmTestUtils.SVN_COMMAND_LINE, getName());
return;
}

ChangeLogMojo mojo = (ChangeLogMojo) lookupMojo(
"changelog", getTestFile("src/test/resources/mojos/changelog/changelogWithBadConnectionUrl.xml"));

Expand Down

0 comments on commit 93d0142

Please sign in to comment.