Skip to content

Commit

Permalink
[MSHADE-459] Adjust to test also with Java 21 (#196)
Browse files Browse the repository at this point in the history
  • Loading branch information
slachiewicz authored Sep 19, 2023
1 parent e56294a commit 64f577b
Show file tree
Hide file tree
Showing 10 changed files with 75 additions and 23 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/maven-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
ff-jdk: "21"
ff-jdk-distribution: "corretto"
40 changes: 40 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-invoker-plugin</artifactId>
<version>3.6.0</version>
<configuration>
<goals>
<goal>package</goal>
Expand Down Expand Up @@ -365,5 +366,44 @@
</plugins>
</build>
</profile>

<!-- TODO remove with parent pom or spotless plugin update https://github.com/diffplug/spotless/issues/1774 -->
<profile>
<id>java11+</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>2.39.0</version>
</plugin>
</plugins>
</build>
</profile>

<profile>
<id>java21+</id>
<activation>
<jdk>[21,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<java>
<palantirJavaFormat>
<version>2.35.0</version>
</palantirJavaFormat>
</java>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
1 change: 1 addition & 0 deletions src/it/MSHADE-321_respectDrpFlag/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlParser

File jarRenamedFile = new File(basedir, "target/shade_321.jar")
assert jarRenamedFile.isFile()
Expand Down
1 change: 1 addition & 0 deletions src/it/projects/MSHADE-185/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlSlurper;

File pomFile = new File( basedir, "dependency-reduced-pom.xml" );
assert pomFile.isFile()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlParser

File pomFile = new File( basedir, "target/dependency-reduced-pom.xml" );
assert pomFile.isFile()
Expand Down
1 change: 1 addition & 0 deletions src/it/projects/dep-reduced-pom-exclusions/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlParser

File pomFile = new File( basedir, "dependency-reduced-pom.xml" )
assert pomFile.isFile()
Expand Down
1 change: 1 addition & 0 deletions src/it/projects/dep-reduced-pom-unique/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import java.io.*;
import java.util.Properties;
import groovy.xml.XmlParser

def drps = basedir.listFiles( { dir, file -> file ==~ "dependency-reduced-.*\\.xml" } as FilenameFilter )

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlParser

File pomFile = new File( basedir, "target/dependency-reduced-pom.xml" );
assert pomFile.isFile()
Expand Down
1 change: 1 addition & 0 deletions src/it/projects/dep-reduced-pom/verify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlParser

File pomFile = new File( basedir, "target/dependency-reduced-pom.xml" );
assert pomFile.isFile()
Expand Down
48 changes: 25 additions & 23 deletions src/it/projects/plugin-descriptor-relocation/verify.groovy
Original file line number Diff line number Diff line change
@@ -1,24 +1,26 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
def shadedJar = new File( basedir, "app/target/mshade-135-1.0.jar")
def pluginXml = new URL( "jar:" + shadedJar.toURL() + "!/META-INF/maven/plugin.xml" )
def plugin = new XmlSlurper().parse( pluginXml.openStream() );
assert plugin.mojos.mojo[0].implementation == "hidden.impl.TestMojo";
assert plugin.mojos.mojo[0].parameters.parameter[0].type == "hidden.impl.Entry";
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import groovy.xml.XmlSlurper

def shadedJar = new File( basedir, "app/target/mshade-135-1.0.jar")
def pluginXml = new URL( "jar:" + shadedJar.toURL() + "!/META-INF/maven/plugin.xml" )
def plugin = new XmlSlurper().parse( pluginXml.openStream() );
assert plugin.mojos.mojo[0].implementation == "hidden.impl.TestMojo";
assert plugin.mojos.mojo[0].parameters.parameter[0].type == "hidden.impl.Entry";
assert plugin.mojos.mojo[0].requirements.requirement[0].role == "hidden.api.Component";

0 comments on commit 64f577b

Please sign in to comment.