Skip to content

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented May 7, 2025

@Pankraz76
Copy link
Author

is this any good? @gnodet

@gnodet
Copy link
Contributor

gnodet commented May 10, 2025

Well, it will impact all maven projects, so it's really disruptive without any idea how much work it will require.

@slawekjaranowski ?

@Pankraz76
Copy link
Author

Pankraz76 commented May 10, 2025

all maven projects

this is by design then. We waiting for rewrite to deliver quick fix. @timtebeek

Might be doable with s&r as done in this PR.

This change will rollout instantly, right? So all have to migrate not just when going to latest version?

@timtebeek
Copy link

Good to have some wider context.. I'm traveling so can't pick up that recipe request for the coming weeks myself, but should be able to fit in a review.

@Pankraz76 Pankraz76 mentioned this pull request May 10, 2025
@slawekjaranowski
Copy link
Member

Well, it will impact all maven projects, so it's really disruptive without any idea how much work it will require.

@slawekjaranowski ?

Exactly we use shared configuration for all Maven project.
Version of shared is defined in Maven parent pom as property:

https://github.com/apache/maven-parent/blob/237aabdc41f90c7de15ebaafa27643ed80e5f4da/pom.xml#L972

So we can override it if really needed during parent upgrade.

We also use the same configuration for mojohaus projects:
https://github.com/mojohaus/mojo-parent/blob/979b051b927d24226bd78d0521c108feb29ee456/pom.xml#L309-L312

@Pankraz76
Copy link
Author

disruptive

image

IDE can fix this.

Assuming this is out happy path and remaining violations are small better not existent.

Can we pull this change and then migrate, or will an merge apply instant and enforcing the new style?

@Pankraz76
Copy link
Author

Pankraz76 commented May 16, 2025

how is this being released, pull, or push?

On pull, we could merge and then try migration by IDE.

@Pankraz76 Pankraz76 closed this May 20, 2025
@Pankraz76 Pankraz76 reopened this May 23, 2025
@slachiewicz slachiewicz closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants