Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-685] assert some things #16

Merged
merged 4 commits into from
Feb 24, 2020
Merged

[MSHARED-685] assert some things #16

merged 4 commits into from
Feb 24, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 23, 2020

@michael-o also fixes a couple of FindBugs warnings

@elharo elharo requested a review from michael-o February 23, 2020 23:00
@elharo
Copy link
Contributor Author

elharo commented Feb 23, 2020

See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/i848/3/

Changes:

  • restore asserts

5 tests failed.
FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk14 / Build windows-jdk14 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk11 / Build windows-jdk11 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk8 / Build windows-jdk8 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk7 / Build windows-jdk7 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk13 / Build windows-jdk13 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

michael-o
michael-o requested changes Feb 24, 2020
View reviewed changes
src/test/java/org/apache/maven/shared/utils/io/DirectoryScannerTest.java Outdated
@@ -50,7 +50,10 @@ private void createTestData()
{
File rootDir = tempFolder.getRoot();
File folder1 = new File( rootDir, "folder1" );
folder1.mkdirs();
if (!folder1.mkdirs())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/test/java/org/apache/maven/shared/utils/io/DirectoryScannerTest.java Outdated
@@ -60,7 +63,10 @@ private void createTestData()
FileTestHelper.generateTestFile( new File( folder1, "file5.dat" ), 15 );

File folder2 = new File( folder1, "ignorefolder" );
folder2.mkdirs();
if (!folder2.mkdirs())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

michael-o
michael-o approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and merge.

@elharo elharo merged commit 5769481 into master Feb 24, 2020
@elharo elharo deleted the i848 branch February 24, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @michael-o