Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove call to deprecated method #58

Merged
merged 2 commits into from
Jul 20, 2020
Merged

remove call to deprecated method #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1048c85
remove call to deprecated method
elharo Jul 20, 2020
268520e
revert pom
elharo Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
* under the License.
*/

import org.apache.maven.shared.utils.io.IOUtil;
import org.apache.maven.shared.utils.xml.pull.XmlPullParserException;
import org.xml.sax.Attributes;
import org.xml.sax.InputSource;
Expand Down Expand Up @@ -95,10 +94,10 @@ public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String encoding
* @return the built dom
* @throws XmlPullParserException in case of an error
*/
public static Xpp3Dom build( @WillClose Reader reader, boolean trim )
public static Xpp3Dom build( @WillClose Reader in, boolean trim )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@param not updated

throws XmlPullParserException
{
try
try ( Reader reader = in )
{
DocHandler docHandler = parseSax( new InputSource( reader ), trim );
reader.close();
Expand All @@ -108,10 +107,6 @@ public static Xpp3Dom build( @WillClose Reader reader, boolean trim )
{
throw new XmlPullParserException( e );
}
finally
{
IOUtil.close( reader );
}
}

private static DocHandler parseSax( @Nonnull InputSource inputSource, boolean trim )
Expand Down