[MSHARED-969] Environment variable with null value #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzygielo
reviewed
Dec 29, 2020
src/test/java/org/apache/maven/shared/utils/cli/CommandLineUtilsTest.java
Outdated
Show resolved
Hide resolved
pzygielo
reviewed
Dec 29, 2020
src/test/java/org/apache/maven/shared/utils/cli/CommandLineUtilsTest.java
Outdated
Show resolved
Hide resolved
|
@pzygielo thanks for review, I did fix |
mkarg
reviewed
Dec 29, 2020
mkarg
reviewed
Dec 29, 2020
mkarg
reviewed
Dec 29, 2020
| public void environmentVariableWithNullShouldNotBeAddedToList() { | ||
|
|
||
| Commandline commandline = new Commandline(); | ||
| commandline.addEnvironment("TEST_NULL_ENV", null); |
There was a problem hiding this comment.
With reard to my previous comments I'd like to ask the OS experts what sense it make to store null in an environment variable?
There was a problem hiding this comment.
As I wrote before Command Line object has local map of environment variable which are provided to Runtime.exec after translate this map to list of name=value. Translation is done in getEnvironmentVariables.
Please look at my last comment at jira and new test in last update.
MartinKanters
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
I agree with @slawekjaranowski and @elharo, this does fix potential bugs. I approve the changes. Thanks @slawekjaranowski!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.