[MNG-6915] Add a helper method to get the terminal width #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jan 22, 2021
src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jan 26, 2021
pom.xml
Outdated
| @@ -70,7 +70,7 @@ | |||
| <dependency> | |||
| <groupId>org.fusesource.jansi</groupId> | |||
| <artifactId>jansi</artifactId> | |||
| <version>2.0.1</version> | |||
| <version>2.2.0</version> | |||
| <optional>true</optional> | |||
There was a problem hiding this comment.
Why is this marked optional instead of simply declaring it? It feels like unnecessary complexity. The model code checks for its presence but the test code doesn't seem to.
There was a problem hiding this comment.
It must be optional, it is Maven that's responsible to provide it and to decide which features are supported.
Maven 3.3.9 and earlier would otherwise have mixed output.
MartinKanters
previously requested changes
Apr 16, 2021
There was a problem hiding this comment.
Looks good to me, @gnodet! Can you please rebase on master and squash your commits?
gnodet
force-pushed
the
MSHARED-965-help
branch
from
649252d to
f94bb25
Compare
|
@MartinKanters rebased and squashed |
|
running through Jenkins now: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-utils/job/MNG-6915/ |
elharo
dismissed
MartinKanters’s stale review
rebased and squashed as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.