-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSITE-1000] Introduce parser configuration parameter #171
Draft
kwin
wants to merge
2
commits into
master
Choose a base branch
from
feature/configure-parser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
feature/configure-parser
branch
from
December 30, 2023 11:50
a3ef3ae
to
654f8be
Compare
kwin
commented
Dec 30, 2023
import org.apache.maven.shared.utils.io.MatchPattern; | ||
import org.apache.maven.shared.utils.io.MatchPatterns; | ||
|
||
public class ParserConfiguration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kwin
commented
Jan 2, 2024
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java
Outdated
Show resolved
Hide resolved
kwin
force-pushed
the
feature/configure-parser
branch
from
January 4, 2024 10:48
654f8be
to
99ae8e0
Compare
kwin
force-pushed
the
feature/configure-parser
branch
from
January 4, 2024 17:30
99ae8e0
to
8a87442
Compare
michael-o
reviewed
Jan 7, 2024
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
Outdated
Show resolved
Hide resolved
@kwin Can you adapt to recent changes to the sitetools PR? I'd like to review this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP to gather early feedback
Depends on apache/maven-doxia-sitetools#126