Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated methods #198

Merged
merged 7 commits into from
Jul 27, 2024
Merged

Replace deprecated methods #198

merged 7 commits into from
Jul 27, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 21, 2024

@elharo elharo requested a review from michael-o July 21, 2024 12:49
@elharo elharo marked this pull request as ready for review July 21, 2024 12:51
michael-o
michael-o requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parts of the Doxia stuff needs to be reverted. I have retained them for a purpose. Will review later.

michael-o
michael-o requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of backwards compatibility I'd like to keep the marked spots as is.

src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/render/SitemapDocumentRenderer.java Outdated Show resolved Hide resolved
src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java Outdated Show resolved Hide resolved
michael-o
michael-o approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, please squash and merge.

@elharo elharo merged commit bed828c into master Jul 27, 2024
54 checks passed
@elharo elharo deleted the null branch July 27, 2024 17:24
michael-o pushed a commit that referenced this pull request Jul 28, 2024
@elharo @michael-o
Replace deprecated methods (#198)
73b57d3 
* Replace deprecated methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @michael-o