Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Guice injection #218

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Convert to Guice injection #218

merged 7 commits into from
Dec 26, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 20, 2024

No description provided.

@elharo elharo requested a review from michael-o December 20, 2024 11:47
@elharo elharo marked this pull request as ready for review December 20, 2024 11:47
@hendrikebbers
Copy link

Since javax.inject is outdated at has been transferred to Jakarta it would be best to directly use https://mvnrepository.com/artifact/jakarta.inject/jakarta.inject-api

@elharo
Copy link
Contributor Author

elharo commented Dec 24, 2024

Since javax.inject is outdated at has been transferred to Jakarta it would be best to directly use https://mvnrepository.com/artifact/jakarta.inject/jakarta.inject-api

That's a separate decision that would need to be made in core first since it provides these dependencies. For now the project policy is to use javax.inject. See https://maven.apache.org/maven-jsr330.html and https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup

And don't get me started on Oracle's faithlessness on Java EE.

@slachiewicz
Copy link
Member

@hendrikebbers jakarta.inject is not supported by Maven - mainly due to a missing feature in Eclipse Sisu.
See eclipse-sisu/sisu-project#103
eclipse-sisu/sisu-project#92

@elharo
Copy link
Contributor Author

elharo commented Dec 25, 2024

Makes sense. Meanwhile anyone feel like approving this so I can merge and move forward?

@elharo elharo merged commit e6f7094 into master Dec 26, 2024
54 checks passed
@elharo elharo deleted the guice branch December 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants