-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNGSITE-246] Adding .mavenrc documentation #246
base: master
Are you sure you want to change the base?
Conversation
Updating the location of the .mavenrc file
content/markdown/configure.md
Outdated
|
||
### `.mavenrc` file: | ||
|
||
Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use monospace formatting for paths
- Windows, not windows
- environment, not ENV
- Which other properties? I see only environment variables or system relevant configuration
- reading => building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also mavenrc
from two locations: apache/maven@2321e03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-o I have updated the document
Adding monospace
content/markdown/configure.md
Outdated
|
||
### `.mavenrc` file: | ||
|
||
Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project"
-->
"this file defines environment variables and system properties used when Maven builds the project"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%USERPROFILE%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-o did you want to update something to use %USERPROFILE%
? Not sure what is being requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.