Skip to content

Conversation

@slawekjaranowski
Copy link
Member

According to recommendation a few lines below

According to recommendation a few lines below
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

@slawekjaranowski
Copy link
Member Author

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

We have text:

Using an https://spdx.org/licenses/}SPDX identifier as the license name is recommended.

So how should be ...

I merged similar in ASF parent pom 😄

@michael-o
Copy link
Member

Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.

We have text:

Using an https://spdx.org/licenses/}SPDX identifier as the license name is recommended.

So how should be ...

I merged similar in ASF parent pom 😄

I know that we have it and only because we don't have an id element. For me, it feels wrong, honestly, but I won't object to merge it.

@kwin
Copy link
Member

kwin commented Dec 13, 2022

For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)

@michael-o
Copy link
Member

For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)

Real men don't wear clothes with labels, they have custom-tailored.

@slawekjaranowski slawekjaranowski merged commit 598dd02 into master Dec 13, 2022
@slawekjaranowski slawekjaranowski deleted the SPDX branch December 13, 2022 22:01
@jira-importer
Copy link

Resolve #1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants